sven-lange-last commented on a change in pull request #4159: Add additional
debug information to Loadbalancer.
URL:
https://github.com/apache/incubator-openwhisk/pull/4159#discussion_r239114632
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
##########
@@ -242,8 +242,11 @@ class ShardingContainerPoolBalancer(
override def publish(action: ExecutableWhiskActionMetaData, msg:
ActivationMessage)(
implicit transid: TransactionId): Future[Future[Either[ActivationId,
WhiskActivation]]] = {
+ val isBlackboxInvocation = action.exec.pull
+ val actionType = if (!isBlackboxInvocation) "non-blackbox" else "blackbox"
Review comment:
I suggest to use the term `managed` instead of `non-blackbox` because it is
used everywhere else as well. This will also change an existing message below
(https://github.com/apache/incubator-openwhisk/pull/4159/files#diff-f749d7d6e4e8ae0b5202a75af1136202R289).
A simple text search for `non-blackbox` reveals that nobody relies on the
term in this github repo. It should be safe to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
