chetanmeh commented on a change in pull request #4176: additional container
factory dns configuration
URL:
https://github.com/apache/incubator-openwhisk/pull/4176#discussion_r241638236
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.scala
##########
@@ -27,6 +27,8 @@ import scala.concurrent.Future
case class ContainerArgsConfig(network: String,
dnsServers: Seq[String] = Seq.empty,
+ dnsSearch: Seq[String] = Seq.empty,
Review comment:
Going forward we should look into opening up the docker argument
configuration in a generic way such that any argument can be configured without
requiring code change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
