rabbah commented on a change in pull request #4186: Track activation counts in
ContainerPool (not ContainerProxy)
URL:
https://github.com/apache/incubator-openwhisk/pull/4186#discussion_r245491073
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/Container.scala
##########
@@ -207,6 +207,7 @@ trait Container {
private def closeConnections(toClose: Option[ContainerClient]): Future[Unit]
= {
toClose.map(_.close()).getOrElse(Future.successful(()))
}
+ override def toString() = if (id == null) "no-container-id" else id.toString
Review comment:
thanks for explanation - maybe should be a comment instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
