rabbah commented on a change in pull request #4164: Add warn log when too many
requests happened
URL:
https://github.com/apache/incubator-openwhisk/pull/4164#discussion_r245491404
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/AuthorizedRouteDispatcher.scala
##########
@@ -86,7 +89,11 @@ trait BasicAuthorizedRouteProvider extends Directives {
case NotFound =>
handleEntitlementFailure(
RejectRequest(NotFound,
Some(ErrorResponse(Messages.resourceDoesntExist(resource.fqname), transid))))
- case _ => handleEntitlementFailure(t)
+ case code =>
+ if (code == TooManyRequests) {
+ logger.warn(this, s"${resource.id} invoked failed: ${t}")
+ }
Review comment:
There was... it's now a debug level statement. @ningyougang does this not
suffice? (we can refactor the debug statement so that the concurrent throttle
check emits a more specific messages.)
https://github.com/apache/incubator-openwhisk/blob/be1e3a19c02956c9be85023a0bb0ff399c21444d/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/ActivationThrottler.scala#L41-L50
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
