markusthoemmes commented on a change in pull request #4185: recreate http
client on resume()
URL:
https://github.com/apache/incubator-openwhisk/pull/4185#discussion_r248230635
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerContainer.scala
##########
@@ -174,8 +174,9 @@ class DockerContainer(protected val id: ContainerId,
override def suspend()(implicit transid: TransactionId): Future[Unit] = {
super.suspend().flatMap(_ => if (useRunc) runc.pause(id) else
docker.pause(id))
}
- def resume()(implicit transid: TransactionId): Future[Unit] =
- if (useRunc) { runc.resume(id) } else { docker.unpause(id) }
+ override def resume()(implicit transid: TransactionId): Future[Unit] = {
+ if (useRunc) { runc.resume(id) } else { docker.unpause(id) }.map(_ =>
super.resume())
Review comment:
good question @sven-lange-last. Better safe than sorry and make an interim
value or put parentheses around the if expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
