chetanmeh commented on a change in pull request #4305: Use runtime tags
specified in runtime manifest for YARNContainerFactoryTests
URL:
https://github.com/apache/incubator-openwhisk/pull/4305#discussion_r260600721
##########
File path:
tests/src/test/scala/org/apache/openwhisk/core/containerpool/yarn/test/YARNContainerFactoryTests.scala
##########
@@ -35,29 +36,18 @@ import scala.concurrent.Await
import scala.concurrent.duration._
@RunWith(classOf[JUnitRunner])
-class YARNContainerFactoryTests extends Suite with BeforeAndAfter with
FlatSpecLike {
-
+class YARNContainerFactoryTests extends Suite with BeforeAndAfter with
FlatSpecLike with ExecHelpers {
val images = Array(
- ImageName("nodejs6action", Option("openwhisk"), Option("latest")),
- ImageName("python3action", Option("openwhisk"), Option("latest")))
-
- val runtimes: String = "{\"runtimes\":{" +
-
"\"nodejs\":[{\"kind\":\"nodejs:6\",\"image\":{\"prefix\":\"openwhisk\",\"name\":\"nodejs6action\",\"tag\":\"latest\"}}],"
+
-
"\"python\":[{\"kind\":\"python:3\",\"image\":{\"prefix\":\"openwhisk\",\"name\":\"python3action\",\"tag\":\"latest\"}}]"
+
- "}}"
-
- implicit val logging: PrintStreamLogging = new PrintStreamLogging()
- implicit val whiskConfig: WhiskConfig = new WhiskConfig(
- Map(wskApiHostname -> "apihost", runtimesManifest -> runtimes) ++
wskApiHost)
-
+ ImageName("nodejs6action", Option("openwhisk"), imageTag("nodejs:6")),
Review comment:
As manifest is global the test needs to reset it back to default. It may be
worthwhile to implement a [fixture][1] to take care of properly setting the
manifest for specific test
[1]: http://www.scalatest.org/user_guide/sharing_fixtures#loanFixtureMethods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
