mhenke1 commented on a change in pull request #4299: Avoid that actions do not
stop after action timeout when logging heavily
URL:
https://github.com/apache/incubator-openwhisk/pull/4299#discussion_r260653567
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskActivation.scala
##########
@@ -124,6 +124,11 @@ case class WhiskActivation(namespace: EntityPath,
}
def withoutLogs = copy(logs =
ActivationLogs()).revision[WhiskActivation](rev)
def withLogs(logs: ActivationLogs) = copy(logs =
logs).revision[WhiskActivation](rev)
+
+ def isTimedoutActivation = {
+
annotations.getAs[Boolean](WhiskActivation.timeoutAnnotation).getOrElse(false)
+ }
Review comment:
@rabbah I second your thoughts to to make the time-out annotation
consistently available in the controller. I especially like the added value
making the timeout case more visible to the user. Since the underlying problem
that triggered this PR is solved with these invoker side changes, I volunteer
to take the controller changes to my list and address it in a subsequent PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
