dgrove-oss commented on a change in pull request #72: Static Build, Versioning and Support for More Languages URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/72#discussion_r260890697
########## File path: actionloop/build.gradle ########## @@ -15,5 +15,19 @@ * limitations under the License. */ -ext.dockerImageName = 'actionloop' +ext.dockerImageName = 'actionloop-v1.0.2' Review comment: Do we really want to embed a full semantic version into the name of the image? It's going to look odd when the thing is called actionloop-v1.0.2:x.y.z (image name + semvar image version for proper apache release of this component). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
