jthomas edited a comment on issue #148: handle 429 responses with exponential 
backoff retries
URL: 
https://github.com/apache/incubator-openwhisk-client-js/issues/148#issuecomment-468202712
 
 
   As discussed in #119, I didn't agree with introducing generic retry 
behaviour for all lower-level networking issues. However, I can see the case 
for a retry mechanism for explicit cases like the HTTP 429 returned by the 
platform API. 
   
   This should be turned off by default ("no surprises for the user and no 
breaking changes") and configurable through constructor options as @alexkli 
suggested. Exponential back-off is the correct approach. 
   
   @alexkli If you want to provide a PR - we can discuss the approach? 
   
   I was going to start the process of a release this library to push out the 
recent change 
(https://github.com/apache/incubator-openwhisk-client-js/pull/147) but will 
wait until this is in?
   
   Maybe it would be better to implement this in the client module rather than 
the resource? 
https://github.com/apache/incubator-openwhisk-client-js/blob/master/lib/client.js

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to