chetanmeh opened a new pull request #4323: Include Kamon Datadog dependencies URL: https://github.com/apache/incubator-openwhisk/pull/4323 Adds [Kamon Datadog](https://github.com/kamon-io/kamon-datadog) dependencies to common so that Kamon Datadog reporter can be configured for setups using Datadog ## Description So far we only include Kamon Statsd reporter. This PR also adds the Kamon Datadog reporter such that it can be configured (if required) on setups which use Datadog for monitoring It pulls in 1 more jars ``` | +--- io.kamon:kamon-datadog_2.12:1.0.0 | | +--- org.scala-lang:scala-library:2.12.1 -> 2.12.7 | | +--- io.kamon:kamon-core_2.12:1.1.2 -> 1.1.3 (*) | | +--- com.squareup.okhttp3:okhttp:3.10.0 (*) | | \--- org.scala-lang.modules:scala-java8-compat_2.12:0.8.0 (*) ``` So far we were maintaining separate repos internally which extend the docker images to include the datadog dependencies. Now with support for some new services (like cache invalidation #4314 ) such an approach increases work. Including this dependency directly should not have any adverse impact and also does not pull in many new jars. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
