rabbah commented on a change in pull request #4329: Redirect http to https and
other nginx config cleanup.
URL:
https://github.com/apache/incubator-openwhisk/pull/4329#discussion_r264013656
##########
File path: ansible/group_vars/all
##########
@@ -209,15 +209,14 @@ nginx:
version: "{{ nginx_version | default('1.13') }}"
port:
http: 80
- api: 443
+ https: 443
ssl:
- path: "{{ openwhisk_home }}/ansible/roles/nginx/files"
- cert: "openwhisk-server-cert.pem"
- key: "openwhisk-server-key.pem"
- password_enabled: false
Review comment:
it's not necessary to have both password_enabled and the password_file
parameter - this chance consolidates both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
