shazron opened a new pull request #153: Fix scancode issues URL: https://github.com/apache/incubator-openwhisk-client-js/pull/153 Unfortunately it still detects `test/integration/prepIntegrationTests.sh` as not being compliant: ``` ./tools/travis/scancode.sh Reading configuration file [/Users/shaz/git/apache/openwhisk/incubator-openwhisk-utilities/scancode/ASF-Release.cfg]... Scanning files starting at [/Users/shaz/git/apache/openwhisk/incubator-openwhisk-client-js/tools/travis/../..]... Scan detected 6 error(s) in 6 file(s): [/Users/shaz/git/apache/openwhisk/incubator-openwhisk-client-js/tools/travis/../../test/integration/prepIntegrationTests.sh]: 1: file does not include required license header. [/Users/shaz/git/apache/openwhisk/incubator-openwhisk-client-js/tools/travis/../../tools/merge-coverage.sh]: 1: file does not include required license header. [/Users/shaz/git/apache/openwhisk/incubator-openwhisk-client-js/tools/travis/../../tools/travis/build.sh]: 1: file does not include required license header. [/Users/shaz/git/apache/openwhisk/incubator-openwhisk-client-js/tools/travis/../../tools/travis/scancode.sh]: 1: file does not include required license header. [/Users/shaz/git/apache/openwhisk/incubator-openwhisk-client-js/tools/travis/../../tools/travis/setup.sh]: 1: file does not include required license header. [/Users/shaz/git/apache/openwhisk/incubator-openwhisk-client-js/tools/travis/../../tools/travis/setupscan.sh]: 1: file does not include required license header. Scan detected 6 error(s) in 6 file(s): ``` .. this is because the license does not start at the first line. We can't put the license on the first line because for shell scripts the shebang must be on the first line. During local testing I couldn't figure out (yet) how to add exclusions to `node_modules` (deleted that) and `tools/travis`...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
