rabbah commented on a change in pull request #4334: Feature flag support to
turn on/off support for provide-api-key annotation
URL:
https://github.com/apache/incubator-openwhisk/pull/4334#discussion_r265121729
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala
##########
@@ -67,7 +67,7 @@ object WhiskActionsApi {
* 2. An [[execAnnotation]] consistent with the action kind; this annotation
is always added and overrides a pre-existing value
*/
protected[core] def amendAnnotations(annotations: Parameters, exec: Exec,
create: Boolean = true): Parameters = {
- val newAnnotations = if (create) {
+ val newAnnotations = if (create && FeatureFlags.requireApiKeyAnnotation) {
Review comment:
i suspect that if this is set to false, some tests will fail.
did you consider also updating this for completeness although there may be
another place or two that don't use this method that could be affected.
https://github.com/apache/incubator-openwhisk/blob/fb0bab64de6634725b409a63ffbb90fee295e8c1/tests/src/test/scala/org/apache/openwhisk/core/controller/test/ControllerTestCommon.scala#L88-L95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
