dubee opened a new pull request #4340: Fix intermittent test failure related to sequence execution error propagation URL: https://github.com/apache/incubator-openwhisk/pull/4340 A test entitled `propagate execution error (timeout) from atomic action to sequence` is failing intermittently with an abnormal initialization error instead of an action timeout error. Since the action that is meant to fail will never complete the init phase, the socket responsible for performing the init may timeout resulting in the abnormal initialization error instead of an action timeout error. Changes here allow for either error message to be returned in the activation record. Invoker log showing the init socket connection timing out: ``` [2019-03-14T04:00:22.911Z] [INFO] [#tid_36f2cb1fe73426dfa3a4f5738e4e990a] [ContainerPool] containerStart containerState: recreatedPrewarm container: Some(ContainerId(0a2e30bb9aa6a91767c247c3ff59c2a0ad81c698815a2ebccd4e67573c7d8aaf)) activations: 1 of max 1 action: initforever namespace: [email protected] activationId: 475025d3eda548d19025d3eda548d13f [2019-03-14T04:00:22.913Z] [INFO] [#tid_36f2cb1fe73426dfa3a4f5738e4e990a] [DockerContainer] sending initialization to ContainerId(0a2e30bb9aa6a91767c247c3ff59c2a0ad81c698815a2ebccd4e67573c7d8aaf) ContainerAddress(172.17.0.33,8080) [2019-03-14T04:00:44.910Z] [INFO] [#tid_36f2cb1fe73426dfa3a4f5738e4e990a] [DockerContainer] initialization result: ConnectionError(java.net.SocketTimeoutException: Read timed out) [2019-03-14T04:00:44.915Z] [INFO] [#tid_36f2cb1fe73426dfa3a4f5738e4e990a] [KafkaProducerConnector] sent message: completed0[0][354] [2019-03-14T04:00:44.915Z] [INFO] [#tid_36f2cb1fe73426dfa3a4f5738e4e990a] [InvokerReactive] posted completion of activation 475025d3eda548d19025d3eda548d13f ``` <!--- Provide a concise summary of your changes in the Title --> ## Description <!--- Provide a detailed description of your changes. --> <!--- Include details of what problem you are solving and how your changes are tested. --> ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
