cbickel commented on a change in pull request #4343: Move runtimesRegistry to pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/4343#discussion_r265517207
########## File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.scala ########## @@ -47,6 +47,8 @@ case class ContainerPoolConfig(userMemory: ByteSize, concurrentPeekFactor: Doubl def cpuShare(reservedMemory: ByteSize) = (totalShare / (userMemory.toBytes / reservedMemory.toBytes)).toInt } +case class RuntimesRegistryConfig(url: String, user: Option[String] = None, password: Option[String] = None) Review comment: Makes totally sense 👍 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
