rabbah commented on a change in pull request #4211: Add `binding` annotation to
record an action path not resolved
URL:
https://github.com/apache/incubator-openwhisk/pull/4211#discussion_r265955733
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
##########
@@ -303,6 +327,10 @@ case class ExecutableWhiskActionMetaData(namespace:
EntityPath,
def toWhiskAction =
WhiskActionMetaData(namespace, name, exec, parameters, limits, version,
publish, annotations)
.revision[WhiskActionMetaData](rev)
+
+ def bindingFullyQualifiedName =
Review comment:
i suggest adding a type decorator on the method for the return value and a
comment, explaining that the result is Some fully qualified name only if
there's a binding, else None.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
