tysonnorris commented on a change in pull request #4326: Invoker backpressure
URL: 
https://github.com/apache/incubator-openwhisk/pull/4326#discussion_r266977836
 
 

 ##########
 File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -61,6 +66,7 @@ class ContainerPool(childFactory: ActorRefFactory => 
ActorRef,
 
   implicit val logging = new AkkaLogging(context.system.log)
 
+  val resourceManager = new 
AkkaClusterContainerResourceManager(context.system, instanceId, self, 
poolConfig)
 
 Review comment:
   No, because those are still maintained strictly by the ContainerPool, 
regardless of ContainerResourceManager impl. These are not potentially "shared" 
resources, at this point at least.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to