ddragosd commented on a change in pull request #4326: Invoker backpressure URL: https://github.com/apache/incubator-openwhisk/pull/4326#discussion_r268360833
########## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala ########## @@ -61,6 +66,7 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef, implicit val logging = new AkkaLogging(context.system.log) + val resourceManager = new AkkaClusterContainerResourceManager(context.system, instanceId, self, poolConfig) Review comment: my confusion is with the naming of `resourceManager` which is a concern shared with multiple classes: ContainerPool, ContainerProxy, ContainerResourceManager, ContainerFactory. I don't have a suggestion on how to solve this, but in a way, I wish this new class would have a name that would allow us to easily understand what it does, and how it stands up when compared to the other classes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
