SugandhaAgrawal opened a new pull request #4395: Replace count suffix with counter URL: https://github.com/apache/incubator-openwhisk/pull/4395 <!--- Provide a concise summary of your changes in the Title --> Replace the `count` suffix for metrics by `counter`. ## Description <!--- Provide a detailed description of your changes. --> Suffix `count` has been used in OpenWhisk code for recording metrics - gauges and histogram which as per definition of graphite data source corresponds to the max value by aggregation. This has been reporting incorrect information. The recommendation is to use any other suffix other than `count`, `max` and `min`, if actual count at given time is the expected output hence changing it in logging logic to `counter`. <!--- Include details of what problem you are solving and how your changes are tested. --> - The data being represented for eg in - Grafana would be reported correctly. Today, due to the use of `count`, the value is aggregated by `max`. - The graphical representation of the `count` metrics would need adaption. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [x] General tooling - [x] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [x] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [x] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
