markusthoemmes commented on a change in pull request #4403: Add detailed error
and reason information to status code
URL:
https://github.com/apache/incubator-openwhisk/pull/4403#discussion_r269688680
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/http/PoolingRestClient.scala
##########
@@ -110,9 +112,17 @@ class PoolingRestClient(
if (response.status.isSuccess) {
Unmarshal(response.entity.withoutSizeLimit).to[T].map(Right.apply)
} else {
- // This is important, as it drains the entity stream.
- // Otherwise the connection stays open and the pool dries up.
- response.discardEntityBytes().future.map(_ => Left(response.status))
+ Unmarshal(response.entity).to[JsObject].flatMap { responseEntity =>
+ val error = responseEntity.fields.get("error").getOrElse("").toString
+ val reason =
responseEntity.fields.get("reason").getOrElse("").toString
Review comment:
Can you encode this schema into a type? If both of them are optional it'll
be like:
```scala
case class Foo(error: Option[String], reason: Option[String])
```
You can then use that in the `Unmarshal(...).to[Foo]` and use the
unmarshalled entity directly rather than relying on an implicit schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
