silvasong commented on a change in pull request #4424: Delete pod when creating
timeout
URL:
https://github.com/apache/incubator-openwhisk/pull/4424#discussion_r271284056
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala
##########
@@ -170,6 +170,15 @@ class KubernetesClient(
}
}.recoverWith {
case e =>
+ Future {
+ kubeRestClient
Review comment:
> Please wrap this in a `blocking` block if the `kubeRestClient`'s actions
are still all blocking. It will instruct the underlying Thread pool to create
enough threads to deal with potentially blocked ones gracefully.
should you consider creating a failure for other reasons, such as network
timeouts, whether delete still makes sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
