mrutkows commented on a change in pull request #57: Fix exclusion directory and 
file matching and add support for reading a top level gitignore file
URL: 
https://github.com/apache/incubator-openwhisk-utilities/pull/57#discussion_r271542424
 
 

 ##########
 File path: scancode/scanCode.py
 ##########
 @@ -549,7 +554,7 @@ def is_dir(path):
             print_warning(WARN_SCAN_EXCLUDED_PATH % excluded_path)
 
     # Display which files where excluded from these paths
-    if args.display_exclusions:
+    if VERBOSE:
 
 Review comment:
   Sometimes the listing of exclusions is not desirable unto itself (even with 
VERBOSE) enabled; would prefer leaving this as a sep. option in addition to 
general verbose.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to