dgrove-oss commented on a change in pull request #447: Add Support to store
Openwhisk Component Images in Hosted Docker Registry.
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/447#discussion_r272373130
##########
File path: helm/openwhisk/templates/_invoker-helpers.tpl
##########
@@ -33,8 +33,12 @@
{{- define "openwhisk.docker_pull_runtimes" -}}
- name: docker-pull-runtimes
- imagePullPolicy: {{ .Values.utility.imagePullPolicy | quote }}
+{{- if .Values.docker.usePrivateRegistry }}
Review comment:
Why put this in an if/else block instead of letting
.Values.docker.registry.name default to an empty string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
