tysonnorris opened a new pull request #4437: S3AttachmentStore: prevent deletion of other s3 bucket keys on doc delete URL: https://github.com/apache/incubator-openwhisk/pull/4437 <!--- Provide a concise summary of your changes in the Title --> In S3AttachmentStore, deleting attachments for entity documents is performed by: * listing bucket keys that match the document name as prefix * deleting each matching key The current matching logic for listing bucket keys specific to a document matches attachment keys for other documents in some cases, where the document name prefix is the same as the to-be-deleted document. ## Description <!--- Provide a detailed description of your changes. --> <!--- Include details of what problem you are solving and how your changes are tested. --> Considering these 2 actions: * <package1>/<action1> * <package1>/<action1>foo deleting <package1>/<action1> will cause deletion of bucket keys: * <package1>/<action1>/attach1 * <package1>/<action1>/attach2 * <package1>/<action1>foo/attach3 * <package1>/<action1>foo/attach3 To repair this, I updated the matching to include a trailing slash, and updated the attachment delete test to verify this. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [x] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
