neerajmangal commented on a change in pull request #447: Add Support to store
Openwhisk Component Images in Hosted Docker Registry.
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/447#discussion_r275234767
##########
File path: helm/openwhisk/templates/_invoker-helpers.tpl
##########
@@ -33,8 +33,12 @@
{{- define "openwhisk.docker_pull_runtimes" -}}
- name: docker-pull-runtimes
- imagePullPolicy: {{ .Values.utility.imagePullPolicy | quote }}
+{{- if .Values.docker.usePrivateRegistry }}
Review comment:
Hi @dgrove-oss, I modified it based on your suggestion and removed an extra
flag(usePrivateRegistry). Now if docker registry is not empty, then charts will
use imagePullSecrets and docker registry provided to pull the images. Let me
know if you have further suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
