style95 commented on issue #4430: Update docker client version to 18.06.3 URL: https://github.com/apache/incubator-openwhisk/pull/4430#issuecomment-483195067 @markusthoemmes With the assumption that we will move forward with 18.09 and just including 18.06 for the deprecation period, docker-18.06 would add about 43MB(36 + 7.2 MB) of overhead. ```bash $ ll -h docker-18.06 total 141M drwxrwxr-x 2 style95 style95 4.0K Feb 20 11:26 ./ drwxr-xr-x 4 style95 style95 4.0K Apr 15 19:03 ../ -rwxr-xr-x 1 style95 style95 36M Feb 20 11:26 docker* -rwxr-xr-x 1 style95 style95 26M Feb 20 11:26 docker-containerd* -rwxr-xr-x 1 style95 style95 15M Feb 20 11:26 docker-containerd-ctr* -rwxr-xr-x 1 style95 style95 4.0M Feb 20 11:26 docker-containerd-shim* -rwxr-xr-x 1 style95 style95 51M Feb 20 11:26 dockerd* -rwxr-xr-x 1 style95 style95 747K Feb 20 11:26 docker-init* -rwxr-xr-x 1 style95 style95 2.8M Feb 20 11:26 docker-proxy* -rwxr-xr-x 1 style95 style95 7.2M Feb 20 11:26 docker-runc* ``` @rabbah Let me clarify the issues. There are the following changes. ### Docker 1.12 -> 18.06 or higher `runc` no more use default(`/run/runc`) directory as a root directory. It uses `/run/docker/runtime-runc/moby`. ### Docker 18.06 -> 18.09 The name of `runc` is changed from `docker-runc` to `runc`. IMHO, there are few options to have multiple versions of docker, but I think it would be easier to configure the version at the deployment time. For example, we can have both versions of docker binaries in the invoker. It will have two binaries, `docker-runc` and just `runc`. Based on the configuration, `DockerClient(RuncClient)` will selectively look for one of them. (Currently, it is hardcoded to `/usr/bin/docker-runc`) ### Keeping docker-1.12 Besides of the above things, If we want to keep docker-1.12, we need to differentiate the ansible script based on the version flag as well. The mounting directory for `runc` will vary between `/run/runc` and `/run/docker/runtime-runc/moby`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
