ddragosd commented on a change in pull request #119: An ability to run on
Knative along with OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119#discussion_r276001196
##########
File path: core/nodejsActionBase/app.js
##########
@@ -15,74 +15,81 @@
* limitations under the License.
*/
+// __OW_ALLOW_CONCURRENT: see docs/concurrency.md
var config = {
'port': 8080,
'apiHost': process.env.__OW_API_HOST,
- 'allowConcurrent': process.env.__OW_ALLOW_CONCURRENT
+ 'allowConcurrent': process.env.__OW_ALLOW_CONCURRENT,
+ 'requestBodyLimit': "48mb"
Review comment:
given than OW has a limit that is checked earlier, would it be possible for
Knative to check this limit earlier too, so it doesn't have to be maintained in
each container ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
