mrutkows commented on a change in pull request #119: An ability to run on
Knative along with OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119#discussion_r276266344
##########
File path: core/nodejsActionBase/app.js
##########
@@ -15,74 +15,81 @@
* limitations under the License.
*/
+// __OW_ALLOW_CONCURRENT: see docs/concurrency.md
var config = {
'port': 8080,
'apiHost': process.env.__OW_API_HOST,
- 'allowConcurrent': process.env.__OW_ALLOW_CONCURRENT
+ 'allowConcurrent': process.env.__OW_ALLOW_CONCURRENT,
+ 'requestBodyLimit': "48mb"
Review comment:
In general, we were just trying to make any config. settings avail. to the
downstream impls. (in case they needed the value or wished to adjust). Agree
that it can be removed if it has no value at this time beyond the initial
(common) configuration in app.js. In addition, this was a hardcoded value and
had hoped that we would, over time, work to push config. info into the runtime
(via build step perhaps).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
