style95 commented on a change in pull request #4453: Add SPI for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/4453#discussion_r277263241
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/Invoker.scala
##########
@@ -156,25 +156,50 @@ object Invoker {
.isFailure) {
abort(s"failure during msgProvider.ensureTopic for topic $topicName")
}
+
val producer = msgProvider.getProducer(config,
Some(ActivationEntityLimit.MAX_ACTIVATION_LIMIT))
val invoker = try {
- new InvokerReactive(config, invokerInstance, producer, poolConfig)
+ SpiLoader.get[InvokerProvider].instance(config, invokerInstance,
producer, poolConfig, limitConfig)
} catch {
case e: Exception => abort(s"Failed to initialize reactive invoker:
${e.getMessage}")
}
- Scheduler.scheduleWaitAtMost(1.seconds)(() => {
Review comment:
In some invoker implementations, health checking may not be performed via
Kafka.
So I moved this to `InvokerReactive`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
