markusthoemmes commented on a change in pull request #4450: Fix test cases to
also work with nodejs:10 as default nodejs runtime.
URL:
https://github.com/apache/incubator-openwhisk/pull/4450#discussion_r277563108
##########
File path: tests/dat/actions/openFiles.js
##########
@@ -22,7 +22,7 @@ function main(params) {
console.log("opened files = ", openFiles.length);
openFiles.forEach(function(fh) {
- fs.close(fh);
+ fs.close(fh, (err) => {} );
Review comment:
Should this be `closeSync` instead? If not: Can we safely omit the callback
function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
