style95 commented on a change in pull request #4211: Add `binding` annotation
to record an action path not resolved
URL:
https://github.com/apache/incubator-openwhisk/pull/4211#discussion_r277566111
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala
##########
@@ -595,38 +590,6 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
})
}
- /**
- * Constructs a WhiskPackage that is a merger of a package with its packing
binding (if any).
- * This resolves a reference versus an actual package and merge parameters
as needed.
- * Once the package is resolved, the operation is dispatched to the action
in the package
- * namespace.
- */
- private def mergeActionWithPackageAndDispatch(method: HttpMethod,
Review comment:
@upgle Could you elaborate the reason to remove this method a little bit?
It would help people who are not familiar with this change like me to get
the intention more easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
