dgrove-oss opened a new issue #272: improvements to rcverify URL: https://github.com/apache/incubator-openwhisk-release/issues/272 Feedback from an incubator voting thread (https://lists.apache.org/thread.html/9e320277655d931909fd85fe43c49bc4de1696d4e37939126fde7498@%3Cgeneral.incubator.apache.org%3E) > One issue I see with the instructions script is that you are asking people to download it from head, this may make it hard to verify old releases or may give different results during the voting process if changes are made. It may be better to package the verifying script inside the release candidate. > > Another is from the output of the script it’s unclear where it downloaded the files or what rc it is testing, adding that may be useful. It also clones incubator-openwhisk-utilities which might be seen as misleading as should it be cloning incubator-openwhisk-composer so it can compare what’s in version control to what in the release candidate. Again this seem to be checking out head which would change over time so it might be possible for it to give inconstant results. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
