mdeuser commented on a change in pull request #437: Fix tests when
whisk.feature.requireApiKeyAnnotation=false
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/437#discussion_r280434218
##########
File path:
tests/src/test/scala/org/apache/openwhisk/core/cli/test/WskCliBasicUsageTests.scala
##########
@@ -659,18 +657,29 @@ class WskCliBasicUsageTests extends TestHelpers with
WskTestHelpers {
}
wsk.action.create(name, file, web = Some("true"), update = true)
+ val expectedExistingAnnotations = if (requireAPIKeyAnnotation) {
Review comment:
instead of having duplicate JsArray entry lines (common entries are coded
twice), how about defining a single "base" JsArray and conditionally adding the
array element
```
JsObject("key" -> JsString(WhiskAction.provideApiKeyAnnotationName), "value"
-> JsBoolean(false)),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
