ningyougang commented on a change in pull request #4459: Close the consumer
when WakeupExcpetion happened
URL:
https://github.com/apache/incubator-openwhisk/pull/4459#discussion_r281475761
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/connector/kafka/KafkaConsumerConnector.scala
##########
@@ -132,6 +132,10 @@ class KafkaConsumerConnector(
} else {
throw e
}
+ case e: WakeupException =>
+ logging.info(this, s"WakeupException happened when do commit action
for topic ${topic}")
+ close()
Review comment:
Oh, in current github master branch, has no any part that user explicitly
close this consumer using wakeup(). (if wakup is not called forever, this
patch's catch statement will not happen forever also)
Maybe one day in future, for some special scene, may expose a public method
`wakup()` in KafkaConsumerConnector.
I added this patch, just for `future expansion`.
I am not sure community accept this, just try ^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
