sven-lange-last commented on a change in pull request #4430: Update docker
client version to 18.06.3
URL:
https://github.com/apache/incubator-openwhisk/pull/4430#discussion_r281920800
##########
File path: tests/src/test/scala/ha/ShootComponentsTests.scala
##########
@@ -305,9 +305,8 @@ trait ShootComponentUtils {
def file(path: String) = Try(new
File(path)).filter(_.exists).map(_.getAbsolutePath).toOption
val docker = (file("/usr/bin/docker") orElse
file("/usr/local/bin/docker")).getOrElse("docker")
- val dockerPort = WhiskProperties.getProperty(WhiskConfig.dockerPort)
- Seq(docker, "--host", host + ":" + dockerPort, cmd, component)
+ Seq(docker, cmd, component)
Review comment:
I actually opt for keeping the current approach with running Docker commands
against remote systems. From a security perspective, it's a matter of how you
run your Docker daemon. In test environments, you can open a TCP listening
socket to accept connections from remote systems - and on production systems,
you can just disable the TCP listening socket. The rest is how you configure
openwhisk.
Today, the `DockerClientWithFileAccess()` is created with an empty `host`
parameter anyway such that the local Docker daemon BSD stream socket is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
