ddragosd commented on a change in pull request #259: Make Port 443 configurable
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/259#discussion_r282718521
 
 

 ##########
 File path: docker-compose/Makefile
 ##########
 @@ -221,16 +225,13 @@ setup:
        mkdir -p ~/tmp/openwhisk/minio
        cp -r ./apigateway/* ~/tmp/openwhisk/api-gateway-config/api-gateway/
        cp -r ./apigateway/rclone ~/tmp/openwhisk
-       
  
-       $(shell cat ~/tmp/openwhisk/local.env) docker-compose --project-name 
openwhisk up minio 2>&1 > ~/tmp/openwhisk/setup.log &
 
 Review comment:
   `cat ~/tmp/openwhisk/local.env` is not needed anymore b/c the `.env` file is 
loaded automatically. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to