dubee commented on a change in pull request #341: Test resiliency updates
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/341#discussion_r283953862
##########
File path: tests/src/test/scala/system/utils/KafkaUtils.scala
##########
@@ -66,26 +66,27 @@ trait KafkaUtils extends TestHelpers with WskTestHelpers {
new RestAssuredConfig().sslConfig(config)
}
- def createTrigger(assetHelper: AssetCleaner, name: String, parameters:
Map[String, spray.json.JsValue]) = {
+ def createTrigger(assetHelper: AssetCleaner, name: String, parameters:
Map[String, spray.json.JsValue]): String = {
println(s"Creating trigger $name")
val feedCreationResult = assetHelper.withCleaner(wsk.trigger, name) {
(trigger, _) =>
trigger.create(name, feed =
Some(s"/whisk.system/messaging/messageHubFeed"), parameters = parameters)
}
- withActivation(wsk.activation, feedCreationResult, initialWait = 5
seconds, totalWait = 60 seconds) {
Review comment:
Don't need to query for the activation as we already have it from trigger
create.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
