style95 commented on issue #4481: Track Kafka client side metrics via Kamon
URL: 
https://github.com/apache/incubator-openwhisk/pull/4481#issuecomment-492700713
 
 
   @chetanmeh 
   I am using an in-house JMX metric collector to collect major Kafka metrics 
including client metrics. And it is a standalone java application which is 
comprised of 300 lines of codes.
   I think it is one of the common and natural ways as we can find a similar 
approach in many places such as Prometheus.
   https://github.com/prometheus/jmx_exporter
   
   I meant no offense. I just want to discuss this with you.
   I feel like we can take advantage of external components for this kind of 
case.
   For example, we can delegate logs collection to logback or slf4j appender or 
standalone collection agents such as logstash.
   I believe, the more we delegate such logic to external components, the more 
concise we can keep the core logic.
   
   I have not looked into it deeply yet, but there is also a similar 
interesting approach.
   https://github.com/Segence/kamon-jmx-collector
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to