dgrove-oss commented on a change in pull request #463: Provide support for Lean
OpenWhisk configuration
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/463#discussion_r285635629
##########
File path: helm/openwhisk/templates/invoker-agent-pod.yaml
##########
@@ -1,7 +1,7 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
# license agreements; and to You under the Apache License, Version 2.0.
-{{ if .Values.invoker.containerFactory.kubernetes.agent.enabled }}
+{{ if (.Values.invoker.containerFactory.kubernetes.agent.enabled) and not
.Values.controller.lean }}
Review comment:
is adding an extra condition here necessary? Seems like a lean config would
always just set agent.enabled to false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
