[GitHub] [incubator-openwhisk] kiran002 commented on issue #3401: Consolidate action annotation constants

[GitBox]

kiran002 commented on issue #3401: Consolidate action annotation constants
URL: 
https://github.com/apache/incubator-openwhisk/issues/3401#issuecomment-497083044
 
 
   @rabbah 
   Before i go all out and implement these changes, I wanted to get some 
feedback from you guys, So my idea is to have an annotations object
   ```
   object Annotations {
     val FinalParamsAnnotationName = "final"
     val WebActionAnnotationName = "web-export"
     val WebCustomOptionsAnnotationName = "web-custom-options"
     val RawHttpAnnotationName = "raw-http"
     val RequireWhiskAuthAnnotation = "require-whisk-auth"
     val ProvideApiKeyAnnotationName = "provide-api-key"
   }
   ```
   and i intend to change all instances of 
   
   ```
    annotations = Map(WhiskAction.provideApiKeyAnnotationName -> 
JsBoolean(true)))
   ```
   to
   ```
    annotations = Map(Annotations.ProvideApiKeyAnnotationName -> 
JsBoolean(true)))
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services