chetanmeh commented on a change in pull request #4326: Invoker backpressure
URL:
https://github.com/apache/incubator-openwhisk/pull/4326#discussion_r289351136
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##########
@@ -195,8 +243,10 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
// Add this request to the buffer, as it is not there yet.
runBuffer = runBuffer.enqueue(r)
}
- // As this request is the first one in the buffer, try again to
execute it.
- self ! Run(r.action, r.msg, retryLogDeadline)
+ if (!poolConfig.clusterManagedResources) {
Review comment:
> //cannot do this in cluster managed resources, since it will introduce a
tight loop
Why the distinction here between cluster managed and non cluster managed
case? Would not the tight loop would exist for both cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
