duynguyen opened a new pull request #4503: Add option for appending runtimes registry to user provided images URL: https://github.com/apache/incubator-openwhisk/pull/4503 Currently, when `whisk.container-factory.runtimes-registry.url` is set to a specific registry, default runtime images in the manifest are pulled from that registry. Other images provided by users are left intact. In a multi-region and multi-cloud deployment of OpenWhisk, it is useful for the system operators to force all runtime images (default and blackbox) to be pulled from a single registry. This requires the registry hostname components be parsed from image names. ## Description This PR: - makes ImageName registry aware: differentiate `registry` and `prefix` in ImageName parser. - adds option to automatically append system registry hostname to user images, if they do not contain any hostname. Decision tree: 1. If `whisk.container-factory.runtimes-registry.url` is not set, all images are retrieved from Docker Hub. 2. If `whisk.container-factory.runtimes-registry.url` is set to a runtime registry, default runtime images are pull from this custom registry. For blackbox images: 2.1. If `whisk.container-factory.runtimes-registry.url.include-user-images` is not set or set to `false`, blackbox images provided by users are pull as is (no change in image name). 2.2. If `whisk.container-factory.runtimes-registry.url.include-user-images` is set to `true`, blackbox images provided by users are prefixed with system registry in `ImageName`, and blackbox images are pulled from the custom registry. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
