chetanmeh commented on a change in pull request #4504: Remove default port on
api host.
URL:
https://github.com/apache/incubator-openwhisk/pull/4504#discussion_r290270071
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/WhiskConfig.scala
##########
@@ -54,8 +54,16 @@ class WhiskConfig(requiredProperties: Map[String, String],
val dockerEndpoint = this(WhiskConfig.dockerEndpoint)
val dockerPort = this(WhiskConfig.dockerPort)
- val wskApiHost = this(WhiskConfig.wskApiProtocol) + "://" +
this(WhiskConfig.wskApiHostname) + ":" + this(
- WhiskConfig.wskApiPort)
+ val wskApiHost = {
Review comment:
Yeah seems like values are empty which cause the parser to fail. May be an
approach like below?
```scala
val wskApiHost = Try(
Uri.normalize(
this(WhiskConfig.wskApiProtocol) + "://" +
this(WhiskConfig.wskApiHostname) + ":" + this(WhiskConfig.wskApiPort)))
.getOrElse("")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
