chetanmeh commented on a change in pull request #4503: Add option for appending runtimes registry to user provided images URL: https://github.com/apache/incubator-openwhisk/pull/4503#discussion_r291153064
########## File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.scala ########## @@ -51,7 +51,9 @@ case class ContainerPoolConfig(userMemory: ByteSize, concurrentPeekFactor: Doubl case class RuntimesRegistryCredentials(user: String, password: String) -case class RuntimesRegistryConfig(url: String, credentials: Option[RuntimesRegistryCredentials]) +case class RuntimesRegistryConfig(url: String, + includeUserImages: Option[Boolean] = None, Review comment: Instead of using an optional boolean it would be better to not define any value and let the default value (`false`) be defined in application.conf itself. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
