neerajmangal commented on a change in pull request #482: Add configurations for
prometheus and metrics
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/482#discussion_r295149378
##########
File path: helm/openwhisk/templates/invoker-pod.yaml
##########
@@ -169,7 +169,22 @@ spec:
# properties for zookeeper connection
- name: "ZOOKEEPER_HOSTS"
value: "{{ include "openwhisk.zookeeper_connect" . }}"
-
+{{ if .Values.metrics.prometheusEnabled }}
+ - name: "OPENWHISK_ENCODED_CONFIG"
Review comment:
Just a suggestion, instead of having `OPENWHISK_ENCODED_CONFIG` can we have
Config_whisk_metrics_prometheusEnabled env to true, if that works. As
`OPENWHISK_ENCODED_CONFIG` env is general purpose typesafe config file but here
it seems only applicable when `.Values.metrics.prometheusEnabled `.
In the future, we may think of having all (or most) env generated from
values via templates and then passed for each component separately using
OPENWHISK_ENCODED_CONFIG for consistency. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
