daisy-ycguo commented on a change in pull request #482: Add configurations for
prometheus and metrics
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/482#discussion_r298461394
##########
File path: helm/openwhisk/templates/invoker-pod.yaml
##########
@@ -169,7 +169,22 @@ spec:
# properties for zookeeper connection
- name: "ZOOKEEPER_HOSTS"
value: "{{ include "openwhisk.zookeeper_connect" . }}"
-
+{{ if .Values.metrics.prometheusEnabled }}
+ - name: "OPENWHISK_ENCODED_CONFIG"
Review comment:
I agree with you. But currently the implementation of prometheus
configuration in OpenWhisk core project is using OPENWHISK_ENCODED_CONFIG. See
https://github.com/apache/incubator-openwhisk/pull/4309 . So I have to use
OPENWHISK_ENCODED_CONFIG here.
Maybe you could raise an issue to OpenWhisk core project. After they change,
we can change it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
