rabbah commented on a change in pull request #4537: Add action timeout limit to
invoker assignment message in load balancer
URL:
https://github.com/apache/incubator-openwhisk/pull/4537#discussion_r300128464
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
##########
@@ -289,9 +289,13 @@ class ShardingContainerPoolBalancer(
chosen
.map { invoker =>
+ val memoryLimit = action.limits.memory
+ val memoryLimitInfo = if (memoryLimit == MemoryLimit()) { "std" } else
{ "non-std" }
Review comment:
i'd create singletons for MemoryLimit and TimeLimit so that you're not
consing new instances on every check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
