style95 commented on issue #4532: [WIP] Initial commit for Scheduler URL: https://github.com/apache/incubator-openwhisk/pull/4532#issuecomment-508509860 @markusthoemmes Thank you for the feedback, I wanted this kind of thing. Yes, I have thought a few ways to include this kind of big change. If we agree to accept some components which are not being used in any place at some point, I am happy to do that way. But I couldn't see much difference. For example, if I have 18 modules and am willing to contribute all of them with separate PRs(based on the assumption we accept unused codes), reviewers will review each of them and merge them into the master. And if we have one base branch and merge 18 PRs into the branch one by one, reviewers will also review each of them but just merge them into the base branch instead of the master branch. We can just avoid the unused codes with the later.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
