sven-lange-last opened a new pull request #4553: Lower minimum number of 
available file descriptors in action limit tests
URL: https://github.com/apache/incubator-openwhisk/pull/4553
 
 
   Accept a lower number of file descriptors available for Node.js action code 
with the default Node.js action runtime.
   
   ## Description
   * We see test `org.apache.openwhisk.core.limits.ActionLimitsTests.Action 
limits should fail to invoke an action when it exceeds nofile limit` failing 
permanently on Docker 18.09.3-ce systems - while they work properly on Docker 
17.05.0-ce.
   * The test tries to open more files than allowed from within an action.
   * The test expects that at least max open files (=1024) - 20 = 1004 can be 
opened.
   * The test failed because only 1003 files could be opened.
   * The test makes sure that it's always a cold invocation, so the failure was 
not caused by open files carried over from an earlier invocation.
   
   More details below...
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the 
boxes that apply: -->
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered 
all aspects of the change you're making. -->
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to