jthomas commented on a change in pull request #183: Allow environment level set
of default user-agent
URL:
https://github.com/apache/incubator-openwhisk-client-js/pull/183#discussion_r302933173
##########
File path: lib/client.js
##########
@@ -141,7 +141,7 @@ class Client {
url: this.pathUrl(path),
rejectUnauthorized: !this.options.ignoreCerts,
headers: {
- 'User-Agent': (options && options['User-Agent']) ||
'openwhisk-client-js',
+ 'User-Agent': (options && options['User-Agent']) ||
process.env['USER_AGENT'] || 'openwhisk-client-js',
Review comment:
Environment variable name should follow existing configuration pattern for
the library and start with `__OW` prefix, e.g. `__OW_USER_AGENT`.
https://github.com/apache/incubator-openwhisk-client-js#environment-variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
